Being a Drupal developer, this extension is really valuable for me to adhere to Drupal coding standards.
I found some misbehaviors and I'd like to suggest some fixes.

Menu action Tools->Scan for violations did nothing (and exits without an error) if clicked with one (or more) file selected.
It took some time for me to understand it (I thought it also worked with a single file selected).
After looking at the plugin source code I understood how it works (and documentation is not so clear), so I suggest to (in order of preference):
*) make it visible for both files and folder selection and run a "single file" check when a file is selected (like the project context menu item) and a "folder scan" otherwise
OR
*) add an error message to warn the user that this action should be only run on a folder
OR
*) change its caption to "Scan folder for violations"

I found another misbehavior on the project files context menu.
Item "Check for violations" is enabled both for single and multiple selection BUT its action only runs if a single file is selected (and exits silently if more than one file is selected), so I suggest to:
*) let it work like the first suggestion above: make it visible for both files and folder selection and run a "single file" check when a file is selected (like the project context menu item) and a "folder scan" otherwise
OR
*) let it work with more than one file selected
OR
*) disable it when a folder or more than one file is selected

I looked at source code, but I'm not an experienced NetBeans Plugin developer so I only changed item caption to avoid me falling again into this error.

Best regards
Claudio

Is there an easy way to toggle visibility of highlighting violations in the source code?

Hi,

I have setup the plugin and the dependencies successfully, but when I try to check for violations, nothing happens. I checked the debug.log and found that there was an exception. I've provided the complete stacktrace below, but the problem seems to be the "/" character in the filename. Please help!

phpcs command
c?\software\wamp\bin\php\php5.4.3\phpcs.bat?--standard=Zend
??-w?--report=xml?C?/Workspace/PHP/test.php
Output
Warning??file_put_contents(C?\Program?Files\NetBeans?7.3/phpcs-xml.tmp)??failed?to?open?stream??Permission?denied?in?C?\Software\wamp\bin\php\php5.4.3\pear\PHP\CodeSniffer\Reporting.php?on?line?149 Call?Stack? ????0.0005?????233696???1.??main?()?C?\Software\wamp\bin\php\php5.4.3\phpcs?0 ????0.0094????1267408???2.?PHP_CodeSniffer_CLI->process()?C?\Software\wamp\bin\php\php5.4.3\phpcs?37 ????0.0130????1320408???3.?PHP_CodeSniffer->process()?C?\Software\wamp\bin\php\php5.4.3\pear\PHP\CodeSniffer\CLI.php?614 ????0.0323????1901824???4.?PHP_CodeSniffer->processFile()?C?\Software\wamp\bin\php\php5.4.3\pear\PHP\CodeSniffer.php?466 ????0.0375????2045944???5.?PHP_CodeSniffer_Reporting->cacheFileReport()?C?\Software\wamp\bin\php\php5.4.3\pear\PHP\CodeSniffer.php?1312 ????0.0398????2080920???6.?file_put_contents()?C?\Software\wamp\bin\php\php5.4.3\pear\PHP\CodeSniffer\Reporting.php?149 <?xml?version="1.0"?encoding="UTF-8"?>


Exception: Content is not allowed in prolog.
com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(Unknown Source)
com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(Unknown Source)
de.foopara.phpcsmd.exec.phpcs.PhpcsXMLParser.parse(PhpcsXMLParser.java:43)
de.foopara.phpcsmd.exec.phpcs.Phpcs.run(Phpcs.java:90)
de.foopara.phpcsmd.generics.GenericExecute.execute(GenericExecute.java:24)
de.foopara.phpcsmd.threads.QAThread.qarun(QAThread.java:103)
de.foopara.phpcsmd.generics.GenericExecute.executeQATools(GenericExecute.java:50)
de.foopara.phpcsmd.PHPCSMD.performAction(PHPCSMD.java:44)
org.openide.util.actions.NodeAction.performAction(NodeAction.java:295)
org.openide.util.actions.CallableSystemAction$1.run(CallableSystemAction.java:129)
org.openide.util.actions.ActionInvoker$1.run(ActionInvoker.java:95)
org.openide.util.actions.ActionInvoker$ActionRunnable.actionPerformed(ActionInvoker.java:162)
org.netbeans.core.ModuleActions.invokeAction(ModuleActions.java:109)
org.netbeans.modules.openide.actions.ActionsBridgeImpl.invokeAction(ActionsBridgeImpl.java:60)
org.openide.util.actions.ActionInvoker$ActionRunnable.doRun(ActionInvoker.java:153)
org.openide.util.actions.ActionInvoker$2.run(ActionInvoker.java:110)
org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1432)
org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2044)
pmd command
c?\software\wamp\bin\php\php5.4.3\phpmd.bat?C?/Workspace/PHP/test.php?xml?controversial?naming?codesize?unusedcode?design
Output
<?xml?version="1.0"?encoding="UTF-8"??>


Thanks in advance!

Regards,
Yogaesh

Hi, I'm using NB 7.3 with PHPCSMD 0.6.0.4 on Win7.

There is same problem with empty debug log and empty output.

This can happen the first time you are running phpcsmd.
Try restarting Netbeans and open your Action Items an let them open. Add "PHP Violations" to your ActionItems filter and change the scope to "Show action items for currently edited file only"

Your third suggestion is a project im currently working on. But I did not manage to add Icons to the file. If you have any idea how to do that, you are welcome.

I will try to release the source to github so everybody can help to improve the source

UPDATE: I moved from my private svn to github (see Website above)

Sorry for the delayed answer.

1. I will prove your feature request as soon as possible.
2. I will prove this feature request too :D
3. phpcs, phpmd, phpcpd and pdepend are supposed to work with php files. You have to write your own Sniffs and Coding Standards in phpcs to check js and/or css
4. Open your "Action Items" (Ctrl + 6) and leave it open. Enable "PHP Violations" in your "Action Items Filter". Go to PHPCSMD Options and check the first two checkboxes. Restart Netbeans. PHPCSMD should scan the file when your are opening it.

Best regards

Hi nedelcumax.

1. Activate Extras
2. Choose Squiz from the top tab row
3. Choose PHP from the left tab column
4. Scroll down and activate "show unreachable code" and don't activate the "ignores"

To test your setting:
1. create a new function in php with a return statement
2. insert some code (e.g. echo "foo") right after the return statement
3. save file
4. if have not activated "update on save", perform a right click on the source and "check for violations"

PHPCSMD should mark the code after the return statement as unreachable code.

I can confirm that with v0.6.0.3 the "java.lang.NoSuchMethodError: org.openide.filesystems.FileObject.getLookup()Lorg/openide/util/Lookup;" error is no longer reproduced in NB 7.2.

Thank you for the support!

Same error with same system except using NetBeans 7.2.1.

Feel free to add me on gtalk/jabber if you need more info : magnetik at jabber dot magnetik dot org

You are still using versin 0.6.0.1, right? If so, update phpcsmd and try again. There are some fixes in 0.6.0.2 which may resolve your problems.

If phpcsmd does not work either, leave a message here please.

@magnetik: What does the debug log say?
Please activate Debug Log in Options -> PHPCSMD
scan for violoations
open PHPCSMD options and click on show
What action did you use?
- Tools in the Menu bar
- right click on source code
- right click on file
- right click on folder

@idefaye: The exception is fixed and i will upload it in a few minutes.

Bye

Hi,

I'm on Windows 7 using Netbeans 7.2.1 on Java 6.

PhpCS is installed correctly. I think I've set up everything correctly, but when I do Action > scan for violation, nothing happens.

Any way to see what the problem is ?

I was developing on the netbeans nightly-build so it added version 1.49 of Project API to the dependencies. New release should be fixed.

Sorry for that!

Hi,

thanks for the information. I uploaded a new version of this plugin and this issue should be fixed.

The new version comes with the ability to set project specific settings (if needed). Just right click on your PHP-Project chose Properties -> PHPCSMD.

There is still the issue on projects containing whitespaces in project path. Some how I can't get it fixed.

Have fun

For some reason the phpcs command does not generate any Output (as i can see, its empty). Thats why the Exception is thrown.

Have you run phpcs inside of d:\ServeurWeb\php-5.3.5-nts folder? If so, try running it outside in any other folder using the command line from the debug log. Some chars are replaced in debug-log so you can't just copy and paste.

Hi,

before all, I wish to thank you for this great tool !!!
It is very very very useful.

As mr3dblond asked for, I vote for a project specific option in the setting page.
It would be a real improvement, and I would be happy too ;)

Eric

@eduardoelias
- escaping whitespaces in filenames will be in the next release

@mr3dblond
- this is phpcsmd not codesniffer
Actualy there is no way to set project specific phpcsmd settings.
I'll take your post as feature request :D

Well, thanks to your log screen, i could see that, because my folder name, wich has an space in it, the command to phpcs, wich is not scaped, returns an error.

1) Thank you for your already done efforts and for the amazing plugin you have!
2) I'll change my folder's name, to one without spaces.
3) I'll suggest you guys, to scape the folder command to allow spaces.

If i can help in anyway, just say.

Hello, i've been trying to fix that problem with no success. I've generated a XML via console and, successfull, it brings warnings and errors and no BOM chars.

Is there a way to look into XML that will be parsed in phpcsmd? maybe a temporary one? Is the code of your plugin open?? I would like to look into it and try to find what is messing up here.

Thanks for your patience and responses! :D

This is the first time i see this error message, but here are some ideas.

It seems there is some content before the opening xml-tag in the phpcs output. Sometimes these are php debug informations such as "Don't use # for comments in ini files".

Just try the following:
1. Create a php script which prints "Hello World"
2. run "php script.php" and see if it realy just prints "Hello World"
3. If not, try to allocate the php error messages
4. Add "error_reporting=E_ERROR" to the phpcs -d option
5. Activate only one of the external programs like phpcs, phpmd etc to check which of them causes the error
6. If nothing helps come back and we will try to find an other solution


It also could be an encoding conflict between your source code and the xml result (but i think it is not)

Thanks for feedback

To your second point:

Did you activated single file scan? Phpcsmd will scan the file on save if:

1. File scan is activated


2. Folder scan is activated, was performed AND the file has violations at this time.

In other words. If the file had no violations and you deactivated singe file scan the file will not be scanned.

I'll try to reproduce the "Windows problem" as soon as possible.

Hi,

there was an experimental timeout i added in 0.5.2.2. Removing this timeout could solve your problem (win7 and winXp).

I deactivated scanning while "Current Project" or "All opened Projects" is activated for performance reasons. Thats why your violations do not disappear and tasks do not come up or were not updated. I implemented a little feature here so you can see allready detected violations in this scopes.
But remember: Files will not be rescanned if one of these scopes is selected or the task bar is closed.

There is only a changeListener which will scan your file on save. (No openListener, no closeLister or something like that). If there is someone who can tell me how to implement such listeners, please don't be shy :)

Ok now lets try 0.5.2.6 ;)

I am waiting for your report :)

EDIT: If the problem still exists, i will upload all versions between 0.5.2.1 and 0.5.2.5 on my webpage. Perhaps you can findout which version causes your error.

Even with a opened Tasktab it works for me now (using version 0.5.2.5). So it must be something else.

I think i solved your problem .. i tested several times on a other mashine but i was not able to reproduce this bug. But after i updated my phpcpd the same error occurs.

If this problem still appears, try activating the phpcpd file mode in addition to folder scan. This should solve your problem too.

Thanks again for your help, to make this plugin work ;)

I was able to reproduce this Bug and i was able to fix it.

It can take a while to remove the Annotations (in dependency to your PC capacities). The other file (which you have not edited) will be rescanned if you open or switch to it, and the Annotations will hopefully disapear there too.

Thanks again for your report, and let me know if you have found more bugs.

To resolve this problem i need some informations.
Which OS do you use?
What's your current Netbeans version?
Do you use any versioning system like svn or git?

Do the annotations still appear in the edited file, the corresponding file or in both files?

You should also check if one of the files belong to a versioning directory. If so try adding versioning directories to the 'ignore regex' and '--exclude' option (e.g. ignore regex='\.svn' and --exclude='.svn').

Edit: I released a new version. This could possibly solve your problem

Yes i know the malfunction of phpcpd detector. At this moment the plugin only scans a single file. I promise to solve this in the future.

Thnx for the comment :D